[IMP] last_ordered_products: improved sale and purchase by adding this module #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s module - In product_product and product_template override method name_search to get last ordered time for selected customer. - Implemented functions to get last_sold_products and last_purchased_products based on customer's invoice and vendor's bill. - Added compute method to get last_order_time and time difference string. - Updated context in sale_order, purchase_order and account_move to get order_type and partner_id in context - In catalog, to re-organize displayed information inherited sale_order and sale_order_line, override some methods to get sale_uom of order line - In catalog, to re-organize displayed information inherited product_view_kanban_catalog view - Extend ProductCatalogOrderLine to get sale_uom in catalog - Patch ProductCatalogKanbanRecord to get information as per the requirement - Extend Autocomplete to get time difference string in product dropdown - Patch ProductLabelSectionAndNoteFieldAutocomplete to override function which will be used to get time difference string
…s module - Optimizing code - Try to remove unnecessary code
…s module - Removed unnecessary code - In product catalog also products will be sorted based on invoice creation date
- testcases added
|
|
- web_tour added to show flow of module
ppch-odoo
force-pushed
the
18.0-imp-last-ordered-products-ppch
branch
from
2795104 to
8f87feb
Compare
- Improved code by removing unnecessary code
ppch-odoo
force-pushed
the
18.0-imp-last-ordered-products-ppch
branch
from
94acb7e to
9e01f9e
Compare
kcv-odoo
suggested changes
Apr 8, 2025
There was a problem hiding this comment.
Thank you for your work!!
Code look fragile and can be easily break. We should not rely that much on context instead we should add something robust and context should be last option and we should not make feature that can be used individually by single app in dependent of multiple main apps
Have a nice day!
| { | ||
| 'name': "Last Ordered Products", | ||
| 'version': '1.0', | ||
| 'depends': ['sale_management', 'purchase', 'stock'], |
There was a problem hiding this comment.
I would not make a module depending on three major app because even if I want to use this feature only in Sale app it will install inventory and purchase module
So, I was thinking something generic only depending on product app which will contain helper methods and fields to compute those date and if needed create other two modules to call those methods or override them
What do you think?
Comment on lines
+17
to
+30
| if self.env.context.get('active_model') == 'sale.order.line': | ||
| partner_id = self.env['sale.order'].browse(self.env.context.get('order_id')).partner_id.id | ||
| order_type = 'sale' | ||
| elif self.env.context.get('active_model') == 'purchase.order.line': | ||
| partner_id = self.env['purchase.order'].browse(self.env.context.get('order_id')).partner_id.id | ||
| order_type = 'purchase' | ||
| elif self.env.context.get('active_model') == 'account.journal': | ||
| active_id = self.env.context.get('active_id') | ||
| if active_id: | ||
| order_type = self.env['account.journal'].browse(active_id).type | ||
| partner_id = self.env.context.get('partner_id') or self.env.context.get('default_partner_id') | ||
| else: | ||
| partner_id = self.env.context.get('partner_id') | ||
| order_type = self.env.context.get('order_type') |
There was a problem hiding this comment.
We should not rely on context too much instead add something robust to compute these fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last ordered time for selected customer.
based on customer's invoice and vendor's bill.
order_type and partner_id in context
sale_order_line, override some methods to get sale_uom of order line
product_view_kanban_catalog view
which will be used to get time difference string